Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change target folder to /target and move on to version 0.13 #124

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Jun 12, 2023

Closes #89

Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@webmaster128 webmaster128 marked this pull request as ready for review June 13, 2023 09:34
Copy link

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmaster128 webmaster128 merged commit 5540c43 into main Jun 19, 2023
5 checks passed
@webmaster128 webmaster128 deleted the outside-target branch June 19, 2023 11:28
@webmaster128
Copy link
Member Author

I tested this with the expected results on a local workspace with 9 contracts. In all cases, no local ./target folder was created. I.e. the optimizer does not mess with the local build directory.

No target cache set (not recommended but still solid)

  • Run 1: 5:58,49 total (the first one created the registry_cache cache. The following ones are a minute faster)
  • Run 2: 4:55,18 total
  • Run 3: 5:00,33 total
  • Run 4: 5:19,70 total

Target mounted (--mount type=volume,source="$(basename "$(pwd)")_cache",target=/target)

  • Run 1: 5:29,11 total
  • Run 2: 27,760 total (huge win here, as expected)
  • Run 3: 28,324 total
  • Run 4: 29,328 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processing custom cargo environment
3 participants