Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Error on missing module for impl Interface for Contract #311

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird linked an issue Feb 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.08%. Comparing base (3617509) to head (501ab1a).

Files Patch % Lines
sylvia-derive/src/parser/contract.rs 44.44% 5 Missing ⚠️
sylvia-derive/src/input.rs 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   85.98%   86.08%   +0.09%     
==========================================
  Files          39       39              
  Lines        2905     2904       -1     
==========================================
+ Hits         2498     2500       +2     
+ Misses        407      404       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird marked this pull request as draft February 27, 2024 11:52
@kulikthebird kulikthebird force-pushed the feat/error_on_missing_module branch 6 times, most recently from 2c0c61c to 53d4af7 Compare February 27, 2024 13:08
@kulikthebird kulikthebird marked this pull request as ready for review February 27, 2024 13:34
@kulikthebird kulikthebird force-pushed the feat/error_on_missing_module branch 6 times, most recently from 7ab2881 to 16d77d2 Compare February 27, 2024 16:50
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes other than that LGTM

sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the feat/add_support_for_sv_prefix branch from 04139f8 to c737e3f Compare March 4, 2024 21:12
@kulikthebird kulikthebird force-pushed the feat/error_on_missing_module branch 3 times, most recently from 5f354bc to 6a78bc8 Compare March 4, 2024 22:16
@kulikthebird kulikthebird changed the base branch from feat/add_support_for_sv_prefix to chore/remove_tarpaulin_exclusions March 4, 2024 22:17
@kulikthebird kulikthebird added this to the 1.0.0 milestone Mar 5, 2024
@kulikthebird kulikthebird force-pushed the chore/remove_tarpaulin_exclusions branch from 315831d to f40ab6d Compare March 5, 2024 11:54
Base automatically changed from chore/remove_tarpaulin_exclusions to main March 5, 2024 12:05
@kulikthebird kulikthebird enabled auto-merge (squash) March 5, 2024 12:09
@kulikthebird kulikthebird merged commit dbfa509 into main Mar 5, 2024
11 checks passed
@kulikthebird kulikthebird deleted the feat/error_on_missing_module branch March 5, 2024 12:20
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on missing module for interface-level impl
2 participants