feat: Remove custom in impl trait #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikthebird
changed the base branch from
main
to
feat/error_on_missing_module
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 86.08% 86.01% -0.08%
==========================================
Files 39 39
Lines 2904 2888 -16
==========================================
- Hits 2500 2484 -16
Misses 404 404 ☔ View full report in Codecov by Sentry. |
jawoznia
reviewed
Feb 29, 2024
jawoznia
approved these changes
Mar 4, 2024
kulikthebird
force-pushed
the
feat/error_on_missing_module
branch
3 times, most recently
from
5f354bc
to
6a78bc8
Compare
kulikthebird
force-pushed
the
feat/remove_custom_in_impl_trait
branch
from
f4328b7
to
bc1aace
Compare
kulikthebird
force-pushed
the
feat/error_on_missing_module
branch
from
6a78bc8
to
24506ad
Compare
kulikthebird
force-pushed
the
feat/remove_custom_in_impl_trait
branch
from
bc1aace
to
e658828
Compare
kulikthebird
force-pushed
the
feat/error_on_missing_module
branch
from
24506ad
to
501ab1a
Compare
kulikthebird
force-pushed
the
feat/remove_custom_in_impl_trait
branch
from
e658828
to
b17503c
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for users to add
#[sv::custom]forimpl Interface for Contract {...}. It was used only by multitest module and it was fixed by this PR.