Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #[contract(module=...)] and #[messages] not needed for trait impl #318

Merged

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird force-pushed the feat/contract_module_and_messages_not_needed_in_traitimpl branch from f3c2180 to 37cc1dd Compare March 5, 2024 13:02
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (5a14db9) to head (51e6547).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
- Coverage   86.01%   85.49%   -0.52%     
==========================================
  Files          39       38       -1     
  Lines        2888     2779     -109     
==========================================
- Hits         2484     2376     -108     
+ Misses        404      403       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird added this to the 1.0.0 milestone Mar 5, 2024
@kulikthebird kulikthebird changed the title feat: #[contract(module=..)] and #[messages] not needed for trait impl feat: #[contract(module=...)] and #[messages] not needed for trait impl Mar 6, 2024
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Also I need to think a bit more how this changes the Api.

sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia-derive/src/querier.rs Outdated Show resolved Hide resolved
sylvia/src/types.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion for future PRs, but otherwise LGTM

sylvia/tests/remote.rs Show resolved Hide resolved
@kulikthebird kulikthebird merged commit de2f306 into main Mar 11, 2024
11 checks passed
@kulikthebird kulikthebird deleted the feat/contract_module_and_messages_not_needed_in_traitimpl branch March 11, 2024 11:26
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants