-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #[contract(module=...)]
and #[messages]
not needed for trait impl
#318
feat: #[contract(module=...)]
and #[messages]
not needed for trait impl
#318
Conversation
f3c2180
to
37cc1dd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 86.01% 85.49% -0.52%
==========================================
Files 39 38 -1
Lines 2888 2779 -109
==========================================
- Hits 2484 2376 -108
+ Misses 404 403 -1 ☔ View full report in Codecov by Sentry. |
#[contract(module=...)]
and #[messages]
not needed for trait impl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. Also I need to think a bit more how this changes the Api.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion for future PRs, but otherwise LGTM
No description provided.