Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #[contract(module=...)] not needed in mt #319

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird changed the base branch from main to feat/contract_module_and_messages_not_needed_in_traitimpl March 5, 2024 13:05
@kulikthebird kulikthebird added this to the 1.0.0 milestone Mar 5, 2024
@kulikthebird kulikthebird force-pushed the feat/contract_module_not_needed_in_mt branch from b294a36 to 57a63a9 Compare March 5, 2024 13:41
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 95.59748% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 84.99%. Comparing base (de2f306) to head (11d1597).

Files Patch % Lines
sylvia/src/multitest.rs 0.00% 4 Missing ⚠️
sylvia-derive/src/multitest.rs 97.64% 2 Missing ⚠️
sylvia-derive/src/message.rs 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   85.49%   84.99%   -0.51%     
==========================================
  Files          38       38              
  Lines        2779     2706      -73     
==========================================
- Hits         2376     2300      -76     
- Misses        403      406       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/multitest.rs Show resolved Hide resolved
sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
sylvia-derive/src/multitest.rs Outdated Show resolved Hide resolved
Base automatically changed from feat/contract_module_and_messages_not_needed_in_traitimpl to main March 11, 2024 11:26
@kulikthebird kulikthebird force-pushed the feat/contract_module_not_needed_in_mt branch from 3477274 to 4883f83 Compare March 11, 2024 11:43
@kulikthebird kulikthebird force-pushed the feat/contract_module_not_needed_in_mt branch from c23bd91 to 11d1597 Compare March 11, 2024 15:47
@kulikthebird kulikthebird self-assigned this Mar 11, 2024
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulikthebird kulikthebird merged commit 0b65f69 into main Mar 11, 2024
11 checks passed
@kulikthebird kulikthebird deleted the feat/contract_module_not_needed_in_mt branch March 11, 2024 16:32
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Introduce new proc-macro for Interface implementation on Contract
2 participants