Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve no instantiation error message #338

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Apr 3, 2024

#98

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.17%. Comparing base (5888a88) to head (bc15684).

Files Patch % Lines
sylvia-derive/src/message.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   85.23%   85.17%   -0.07%     
==========================================
  Files          37       37              
  Lines        2702     2704       +2     
==========================================
  Hits         2303     2303              
- Misses        399      401       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks promising!

@kulikthebird
Copy link
Contributor

Only one thing bothers me - why the code coverage is not calculated properly here?

@jawoznia
Copy link
Collaborator Author

jawoznia commented Apr 4, 2024

Only one thing bothers me - why the code coverage is not calculated properly here?

I think this is because trybuild invokes rustc on it's own per test file (otherwise tests would fail the original process run by us).
Then it makes sense that tarpaulin doesn't incorporate those runs into it's report since those are separate processes.

It's sad as I thought we will be able to cover error cases using trybuild.
Solution to this is not obvious to me at the moment so I will open a separate issue to track it.

@jawoznia jawoznia force-pushed the jawoznia/examples/change_features branch from f30bffa to 7107eeb Compare April 4, 2024 12:33
Base automatically changed from jawoznia/examples/change_features to main April 4, 2024 12:46
@jawoznia jawoznia force-pushed the jawoznia/test/introduce_trybuild branch from c980fd5 to bc15684 Compare April 4, 2024 12:47
@jawoznia jawoznia merged commit 1546e14 into main Apr 4, 2024
5 of 7 checks passed
@jawoznia jawoznia deleted the jawoznia/test/introduce_trybuild branch April 4, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants