Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow storage of Remote<dyn Interface> #367

Merged
merged 1 commit into from
May 9, 2024
Merged

fix: Allow storage of Remote<dyn Interface> #367

merged 1 commit into from
May 9, 2024

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented May 7, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.91%. Comparing base (8cb52a2) to head (837d47b).

Files Patch % Lines
sylvia/src/types.rs 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##           cosmwasm_1     #367      +/-   ##
==============================================
- Coverage       85.25%   84.91%   -0.35%     
==============================================
  Files              37       37              
  Lines            2700     2711      +11     
==============================================
  Hits             2302     2302              
- Misses            398      409      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jawoznia jawoznia requested a review from ethanfrey May 7, 2024 12:08
@jawoznia jawoznia linked an issue May 7, 2024 that may be closed by this pull request
Skip bound check for Contract generic type #369
Closed
kulikthebird
kulikthebird requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though there are two comments to consider

sylvia/src/types.rs Outdated Show resolved Hide resolved
sylvia/tests/remote.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia force-pushed the jawoznia/cosmwasm1/store_remote_in_custom_storage branch from c65289b to efa6539 Compare May 7, 2024 13:13
@jawoznia jawoznia mentioned this pull request May 8, 2024
Closed
ethanfrey
ethanfrey reviewed May 9, 2024
View reviewed changes
sylvia/src/types.rs Outdated Show resolved Hide resolved
ethanfrey
ethanfrey reviewed May 9, 2024
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let me know when it is in a tagged release?

(I shouldn't really approve anything in this repo, but treat this as my 👍)

@jawoznia jawoznia force-pushed the jawoznia/cosmwasm1/store_remote_in_custom_storage branch from efa6539 to 8916d41 Compare May 9, 2024 11:01
@kulikthebird kulikthebird mentioned this pull request May 9, 2024
Merged
@jawoznia jawoznia force-pushed the jawoznia/cosmwasm1/store_remote_in_custom_storage branch 2 times, most recently from 6384b27 to 07ed146 Compare May 9, 2024 12:21
@jawoznia jawoznia requested a review from kulikthebird May 9, 2024 12:34
@jawoznia jawoznia force-pushed the jawoznia/cosmwasm1/store_remote_in_custom_storage branch from 07ed146 to 837d47b Compare May 9, 2024 14:36
kulikthebird
kulikthebird approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm : )

@jawoznia jawoznia merged commit d6a1a4f into cosmwasm_1 May 9, 2024
5 of 7 checks passed
@jawoznia jawoznia deleted the jawoznia/cosmwasm1/store_remote_in_custom_storage branch May 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey left review comments

@kulikthebird kulikthebird kulikthebird approved these changes

@hashedone hashedone Awaiting requested review from hashedone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip bound check for Contract generic type
3 participants
@jawoznia @ethanfrey @kulikthebird