Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Attributes forwarding to message enums and fields #388

Merged
merged 3 commits into from
Jun 28, 2024
Merged

feat: Attributes forwarding to message enums and fields #388

merged 3 commits into from
Jun 28, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird self-assigned this Jun 20, 2024
@kulikthebird kulikthebird linked an issue Jun 20, 2024 that may be closed by this pull request
Add an API to provide additional attributes to be added to generated entities #379
Closed
@kulikthebird kulikthebird changed the base branch from main to tkulik/feat/executors June 20, 2024 09:26
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.38889% with 34 lines in your changes missing coverage. Please review.

Project coverage is 85.83%. Comparing base (90af7d0) to head (d1c24ea).

Files Patch % Lines
sylvia-derive/src/parser/attributes/messages.rs 27.27% 8 Missing ⚠️
sylvia-derive/src/parser/attributes/attr.rs 80.64% 6 Missing ⚠️
sylvia-derive/src/parser/attributes/custom.rs 45.45% 6 Missing ⚠️
sylvia-derive/src/parser/attributes/mod.rs 68.42% 6 Missing ⚠️
sylvia-derive/src/parser/attributes/msg.rs 80.00% 6 Missing ⚠️
sylvia-derive/src/parser/attributes/error.rs 75.00% 1 Missing ⚠️
...rive/src/parser/attributes/override_entry_point.rs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   86.15%   85.83%   -0.33%     
==========================================
  Files          39       40       +1     
  Lines        2789     2866      +77     
==========================================
+ Hits         2403     2460      +57     
- Misses        386      406      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kulikthebird kulikthebird force-pushed the tkulik/feat/attr_forwarding branch 9 times, most recently from 83c408f to 6dcb758 Compare June 25, 2024 07:36
@kulikthebird kulikthebird marked this pull request as ready for review June 25, 2024 07:43
@kulikthebird kulikthebird linked an issue Jun 25, 2024 that may be closed by this pull request
Allow sylvia crates to use cw-orchestrator as well #374
Closed
This was referenced Jun 25, 2024
Closed
Open
jawoznia
jawoznia reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Consider adding test cases with trybuild to cover the errors.

Also, please update the docs on contract and interface macros.

sylvia-derive/src/parser/attributes/mod.rs Outdated Show resolved Hide resolved
sylvia-derive/src/parser/attributes/attr.rs Show resolved Hide resolved
@kulikthebird kulikthebird force-pushed the tkulik/feat/attr_forwarding branch 3 times, most recently from 4f0bfdf to 13650c0 Compare June 27, 2024 08:14
Base automatically changed from tkulik/feat/executors to main June 27, 2024 08:34
jawoznia
jawoznia approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@jawoznia jawoznia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this attribute in doc comments of contract macro.
You can do it on separate PR.

LGTM

@kulikthebird
Copy link
Contributor Author

Please document this attribute in doc comments of contract macro. You can do it on separate PR.

LGTM

I've just created a new issue: #390

@kulikthebird kulikthebird merged commit 55e9667 into main Jun 28, 2024
5 of 7 checks passed
@kulikthebird kulikthebird deleted the tkulik/feat/attr_forwarding branch June 28, 2024 11:35
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Merged
kulikthebird added a commit that referenced this pull request Jul 12, 2024
@github-actions @kulikthebird
chore: release (#366)
18afff1 
## 🤖 New release
* `sylvia`: 1.0.2 -> 1.1.0
* `sylvia-derive`: 1.0.2 -> 1.1.0

<details><summary><i><b>Changelog</b></i></summary><p>

## `sylvia-derive`
<blockquote>

##
[1.1.0](sylvia-derive-v1.0.2...sylvia-derive-v1.1.0)
- 2024-07-12

### Added
- `From` implementation for contract messages of interface messages
([#391](#391))
- Attributes forwarding to message enums and fields
([#388](#388))
- Executors ([#386](#386))
- No ref needed for 'dyn Interface' type in Remote and BoundQuerier
([#382](#382))
- Remove types forwarding to interface in sv::messages
([#361](#361))

### Other
- Update documentation and refactoring
([#393](#393))
- Add trybuild check for two instantiate methods
([#392](#392))
- Update dependecies
- Update proc-macro-crate deps
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Tomasz Kulik <tomek.k@confio.gmbh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawoznia jawoznia jawoznia approved these changes

Assignees

@kulikthebird kulikthebird

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kulikthebird @jawoznia