Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Fee Handling to use 0 or 1 Coin, not N #10

Closed
ethanfrey opened this issue Oct 25, 2022 · 0 comments
Closed

Simplify Fee Handling to use 0 or 1 Coin, not N #10

ethanfrey opened this issue Oct 25, 2022 · 0 comments
Labels
wontfix This will not be worked on

Comments

@ethanfrey
Copy link
Member

There are two different approaches proposed here and in the following issue. Maybe we allow both (as a Param config), but I think best is to choose one. This one is just a minor simplification of the logic:

I found it odd that we change Coin[]. I mean, we could charge 10 OSMO, 3 ION and 1 ibc-transfered ATOM via channel-7 ??? This field allows for N coins. I don't imagine any realistic use-case with N different than 0 or 1. I would rather represent that as *Coin (nil for 0) or simply Coin, where coin.amount.IsZero() represents "no fee".

@alpe alpe added the wontfix This will not be worked on label Jun 5, 2023
@alpe alpe closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants