Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename lastIDKey key #1182

Closed
alpe opened this issue Jan 27, 2023 · 2 comments · Fixed by #1585
Closed

Rename lastIDKey key #1182

alpe opened this issue Jan 27, 2023 · 2 comments · Fixed by #1585
Labels
good first issue Good for newcomers
Milestone
v0.41.0

Comments

@alpe
Copy link
Member

alpe commented Jan 27, 2023

The name can be missleading. In autoincrementID() it is actually the next id key but there are other places to revisit, too
@alpe alpe added the good first issue Good for newcomers label Jan 27, 2023
@alpe alpe added this to the v0.32.0 milestone Jan 31, 2023
@expertdicer expertdicer mentioned this issue Feb 1, 2023
Closed
@alpe
Copy link
Member Author

alpe commented Apr 24, 2023

This was done 🤗

@alpe alpe closed this as completed Apr 24, 2023
@alpe alpe reopened this Aug 30, 2023
@alpe
Copy link
Member Author

alpe commented Aug 30, 2023

The PR was not merged, reopening.

@alpe alpe mentioned this issue Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
v0.41.0
Development

Successfully merging a pull request may close this issue.

Rename key store key attribute to be more concrete CosmWasm/wasmd
1 participant
@alpe