Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy REST endpoints #782

Closed
alpe opened this issue Mar 10, 2022 · 6 comments
Closed

Remove legacy REST endpoints #782

alpe opened this issue Mar 10, 2022 · 6 comments

Comments

@alpe
Copy link
Member

alpe commented Mar 10, 2022

We still have a couple of custom legacy REST endpoints in the wasm module.
The SDK has removed them for their modules in the v0.46 alphas and current master already.

The "grpc-rest-gateway" is in place for some versions already and can be used instead.

Time to remove the legacy REST endpoints?

@ethanfrey ethanfrey added this to the v1.x.0 milestone Mar 17, 2022
@jhernandezb
Copy link
Contributor

We have been using mostly the endpoints from the gateway which are automatically wired from proto generation, and also might be a good idea revisit some of the endpoints like query ones which takes the payload in the URL instead of taking input from a POST request.

@jhernandezb
Copy link
Contributor

jhernandezb commented Aug 31, 2022

any plans on what to do with the legacy endpoints? I think it will be nice to remove them and improve the query endpoint, We do heavily usage of the smart query through rest endpoints but having to encode them through the URL is a bit of an issue.

Also a multi query endpoint could be useful to avoid round trips.

@webmaster128
Copy link
Member

Also a multi query endpoint could be useful to avoid round trips.

This was discussed in #72 and we were not convinved this is the right™️ way to do it. Could you explain the use case there? Happy to re-open #72.

@alpe
Copy link
Member Author

alpe commented Sep 30, 2022

I have reopened #72. Thanks for the link!
IMHO it is important that we do our housekeeping and drop the legacy apis in our codebase.

@jhernandezb to buy you more time for the migration, we can keep only the smart query endpoint. Would this work for you?

@jhernandezb
Copy link
Contributor

I think we should remove them

@alpe alpe modified the milestones: v1.x.0, v0.32.0 Dec 7, 2022
@alpe alpe modified the milestones: v0.yy.0, v0.xx.0 - sdk 47 support Mar 3, 2023
@alpe
Copy link
Member Author

alpe commented Mar 3, 2023

They are all gone in the sdk v47 branch. No need to backport IMHO

@alpe alpe closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants