Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instantiate config command #843

Closed
alpe opened this issue May 6, 2022 · 4 comments · Fixed by #1121
Closed

Update instantiate config command #843

alpe opened this issue May 6, 2022 · 4 comments · Fixed by #1121
Assignees
Labels
help wanted Extra attention is needed optional Not absolutely required for the milestone
Milestone

Comments

@alpe
Copy link
Member

alpe commented May 6, 2022

There is currently no message/ command to modify the instantiate settings on code info except for gov (#796).
This functionality should be limited to the creator who uploaded the code initially.

This can be achieved by adding a new method to the AuthorizationPolicy and calling it in the keeper.setAccessConfig.
Also the change rules in #840 need to be taken into account

@alpe alpe changed the title Update instantiate config Update instantiate config command May 6, 2022
@ethanfrey
Copy link
Member

There is currently no message/ command to modify the instantiate settings on code info except for gov (#796).
This functionality should be limited to the creator who uploaded the code initially.

I am not sure if we want this. The other approach in #840 would break / become fragile with the ability of a non-governance actor to modify this

@ethanfrey
Copy link
Member

If we do this, it should only be the actor who can instantiate the code, not the creator.

Basically, allowing someone with that ability to transfer it or share it

@ethanfrey ethanfrey added this to the v0.28.0 milestone Jun 17, 2022
@ethanfrey ethanfrey removed this from the v0.29.0 milestone Sep 5, 2022
@ethanfrey
Copy link
Member

Removing this from v0.29 milestone as not urgent and needing more discussion first

@ethanfrey ethanfrey added this to the v0.31.0 milestone Nov 4, 2022
@ethanfrey
Copy link
Member

Adding to v0.31.0 as part of the UX around permissioning.

@ethanfrey ethanfrey added the optional Not absolutely required for the milestone label Nov 4, 2022
@alpe alpe added the help wanted Extra attention is needed label Nov 14, 2022
@pinosu pinosu self-assigned this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed optional Not absolutely required for the milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants