Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] Async Ack #1876

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[Do Not Merge] Async Ack #1876

wants to merge 13 commits into from

Conversation

chipshort
Copy link
Contributor

@chipshort chipshort commented May 3, 2024

also fixes #1891
Needs wasmvm release with new message type.

I had to do changes in quite a few places

@chipshort chipshort changed the title [Do Not Merge] Async Ack prototype [Do Not Merge] Async Ack May 23, 2024
@chipshort chipshort marked this pull request as ready for review May 23, 2024 11:26
Copy link

@srdtrk srdtrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Added some comments :)

x/wasm/ibc.go Outdated Show resolved Hide resolved
x/wasm/keeper/handler_plugin.go Show resolved Hide resolved
x/wasm/keeper/handler_plugin.go Outdated Show resolved Hide resolved
@webmaster128 webmaster128 added this to the 0.52 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible problem with the nil ack
3 participants