-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip shared libraries? #222
Comments
It was disabled to allow easier debugging if we hit a crash in Rust, which had happened before due to some race conditions. Once we hit 1.0, we could strip again, and only make custom builds if we need to debug something. |
Is there any value in having a small binary for the shared library? One could argue the symbols do not hurt and may help debug exotic crashed on live chains. If we want to enable stripping, I suggest letting Rust do it directly. There are two ways:
For now, I'll remove all reference to extra OS specific strip tools. |
5MB off of a 50-60MB We could see what the size difference is with the stripped/unstripped DLLs. And then the current size of wasmd and guess what this will effect. But I don't see too much need to optimize for binary size. |
Stripping is currently disabled. We could (should?) re-enable it. It must be performed in the guest (the builder) in order to support stripping for multiple systems.
The text was updated successfully, but these errors were encountered: