Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile cleanups #245

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Makefile cleanups #245

merged 2 commits into from
Jul 15, 2021

Conversation

webmaster128
Copy link
Member

Two commits making stripping and shared lib file extension clearer.

A contribution to #222.

@webmaster128 webmaster128 requested a review from uint July 15, 2021 11:47
ethanfrey
ethanfrey approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
strip was defined but unused in the current build process, right?

@webmaster128
Copy link
Member Author

strip was defined but unused in the current build process, right?

Exactly. It was never used for as long as I work on CosmWasm. The only reference to it was the commented out build-rust variant that included stripping.

@webmaster128 webmaster128 merged commit 1a18672 into main Jul 15, 2021
@webmaster128 webmaster128 deleted the makefile-cleanups branch July 15, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@webmaster128 @ethanfrey