assert_approx_eq macro for nicer testing
#352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Cool stuff!
Can you use the new macro in https://github.com/CosmWasm/wasmvm/blob/v1.1.0/libwasmvm/src/cache.rs#L714-L722?
webmaster128
reviewed
Sep 7, 2022
libwasmvm/src/test_utils.rs
Outdated
Comment on lines
38
to
39
| let smallest = std::cmp::min(left, right); | ||
| let rel_diff = Decimal::from_ratio(largest - smallest, largest); |
There was a problem hiding this comment.
Isn't that the same as this?
Suggested change
| let smallest = std::cmp::min(left, right); | |
| let rel_diff = Decimal::from_ratio(largest - smallest, largest); | |
| let rel_diff = Decimal::from_ratio(left.abs_diff(right), largest); |
The suggestion would be coser to to formula from Wikipedia
There was a problem hiding this comment.
Where does abs_diff come from? These types don't have that method that I've seen
There was a problem hiding this comment.
webmaster128
reviewed
Sep 7, 2022
There was a problem hiding this comment.
Bautiful!
Only open wish is using this in https://github.com/CosmWasm/wasmvm/blob/v1.1.0/libwasmvm/src/cache.rs#L714-L722.
|
Rebase since I wasn't working on the up-to-date |
uint
force-pushed
the
assert-approx-eq
branch
from
e823043
to
9f9542a
Compare
uint
force-pushed
the
assert-approx-eq
branch
from
9f9542a
to
c276a8e
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.