Differentiate between contract and system error #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -207,7 +201,7 @@ func (vm *VM) Query( | |||
| gasMeter GasMeter, | |||
| gasLimit uint64, | |||
| deserCost types.UFraction, | |||
| ) ([]byte, uint64, error) { | |||
| ) (*types.QueryResponse, uint64, error) { | |||
There was a problem hiding this comment.
This should become a "result" too, but we can do that separately: #475
webmaster128
approved these changes
Nov 21, 2023
chipshort
force-pushed
the
398-nested-errors
branch
from
20d57c2
to
d7c4fa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #398
This should also allow wasmd to handle contract errors and vm errors differently