ISS228: removing gdal from setup.py; fix model download check #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #230 +/- ##
==========================================
- Coverage 66.23% 66.05% -0.19%
==========================================
Files 67 67
Lines 4561 4575 +14
==========================================
+ Hits 3021 3022 +1
- Misses 1540 1553 +13
Continue to review full report at Codecov.
|
This was referenced Aug 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with resolving #228, this also fixes #226 by removing
"GDAL"from the list of dependencies - instead, it just throws an error if GDAL isn't already there.