-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flake8 #450
Fix flake8 #450
Conversation
@rodrigoalmeida94 There are a lot of flake8 errors, we have to filter which ones we would like to catch. |
@srmsoumya In the ideal world, we would fix them all. I think this is unreasonable at the moment so I ignored the major ones that look relatively harmless:
These are the ones that are left (after applying black and isort), and I think it makes sense to address:
In any case we should fix these after merging and rebasing with #448 cc @rbavery |
89365a7
to
1365af4
Compare
d6b5627
to
00fae0b
Compare
1365af4
to
66c831f
Compare
I fixed the remaining linter errors so now CI should be green. @rbavery I have added rio_cogeo dependency since in one of the functions we are using |
Let's keep it in as a dependency @rodrigoalmeida94 sicne it's currently used and we also want to better support cogs in the future |
* Add linting with flake8, black & isort - Remove python-env from tox.ini files, use gh-actions matrix for running different python versions - Define tox runs as `tox -e [lint/format/flake8/test]` * Change basepython to python3 from python3.9. Add test run with tox. * Add python3.10 to the github runner matrix * Use ubuntu-small osgeo container - Tested github-actions locally using act. - osgeo ubuntu-large images are 1.4 GB in size, takes some time to run this locally - Replacing this with ubuntu-small runs it faster with no side effects * Add release Actions workflow (#449) * Uncomment tox * Update job name to test * Add release workflow only on main and with tag * Fix flake8 (#450) * lint is flake8 * Remove - in order to not ignore exit code * Add extended ignores for flake8 * Rm unused vars * Remove extra # * Rm unused var * Add rio-cogeo dependency * Fix undefined variable, ignore ambigous name * Rm flake8 * Fix unused imports F401 * Remove - * Add cv2 dependencies * Format * Check if formatting passes * Move black/isort/flake8 config to setup.cfg * Add pre-commit config with isort, balck and flake8 * Add pre-commit dep Co-authored-by: SRM <soumya@developmentseed.org>
Description
Flake8 step is now lint (
tox -e lint
).