Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for PKCS10 and refactor of import/export formats #101

Merged
merged 124 commits into from
Dec 11, 2023

Conversation

bgrieder
Copy link
Contributor

@bgrieder bgrieder commented Nov 24, 2023

Features

  • Support for certificate generation using the Certify KMIP operation and a PKCS#10 or a public key
  • Support for most standardized encoding formats on import.export: PKCS#8, PKCS#1, SEC1, X509, PKCS#12
  • Improvements to the Locate functionality for attributes and tags
  • Support for the Get Attributes KMIP operation
  • Database: support for more elaborate atomic operations
  • Replaced part of Rust Crypto with openssl for more standardized module support
  • Deactivated automatic verification, which will be reallocated for the future Validate KMIP operation support
  • Deactivated certificate "quick create feature," which will be revisited to better fit in KMIP specs

Bug Fixes

  • Redis-Findex: create now checks for the pre-existence of the object
  • Better KMIP compliance:
    • for KeyBlock #76
    • default export formats #78

This is a BIG PR

Many files are affected by the UniqueIdentifier fix and the import/export format fix.

The only files really worth checking for errors are the server-side files:

In crate/server/src/core/operations/

  • certify.rs
  • export.rs
  • import.rs

In crate/server/src/core/certificate/

  • find.rs
  • tags.rs

The rest of the modifications should really be covered by the unit tests and the clippy linter.

@bgrieder bgrieder changed the base branch from main to develop November 24, 2023 08:29
@Manuthor Manuthor merged commit dc2a793 into develop Dec 11, 2023
32 checks passed
@Manuthor Manuthor deleted the 71-fix-tests branch December 11, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants