Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added russian translation, Improved dialog design and Settings page look better #118

Merged
merged 17 commits into from Jun 29, 2022

Conversation

remaker17
Copy link
Contributor

Russian translation
Slightly optimized code
Improved dialog design
Settings page now look better

app/build.gradle Outdated Show resolved Hide resolved
@remaker17 remaker17 closed this Jun 29, 2022
@PranavPurwar
Copy link
Collaborator

Why did you close it?

@remaker17
Copy link
Contributor Author

remaker17 commented Jun 29, 2022

I need to fix some codes, otherwise you'll merge.

@PranavPurwar
Copy link
Collaborator

okay

@remaker17 remaker17 reopened this Jun 29, 2022
@PranavPurwar
Copy link
Collaborator

Should I merge it now?

@remaker17
Copy link
Contributor Author

Should I merge it now?

It's up to you, but there is one small problem, the button is not displayed when the keyboard is opened in the main activity.

@PranavPurwar
Copy link
Collaborator

That's not an issue currently as it's not the main thing the users would do while editing code

@PranavPurwar PranavPurwar merged commit ed9a574 into Cosmic-Ide:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants