Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom /txs endpoint #147

Merged
merged 1 commit into from Jan 31, 2022
Merged

Remove custom /txs endpoint #147

merged 1 commit into from Jan 31, 2022

Conversation

giansalex
Copy link
Member

This reverts pull request #51

  • Keplr supports cosmos-sdk 0.44x chains
  • The cosmoshub mainnet (sdk v0.44) don't have this endpoint

@giansalex
Revert "Merge pull request CosmosContracts#51 from CosmosContracts/di…
61e7489 
…mi/txs-endpoint"

This reverts commit e507450, reversing
changes made to 8e8bcdf.
@the-frey
Copy link
Collaborator

Do we know of anybody relying on this endpoint @dimiandre ?

@giansalex
Copy link
Member Author

giansalex commented Jan 30, 2022 •
edited

main reason to remove this endpoint is the cosmoshub doesn't have it either, or i haven't seen it in gaia code v6.0

was initially removed due to a vulnerability

@dimiandre
Copy link
Member

Good to remove

@the-frey the-frey merged commit 2476253 into CosmosContracts:main Jan 31, 2022
@giansalex giansalex deleted the remove-txs-path branch January 31, 2022 13:21
the-frey added a commit that referenced this pull request Feb 2, 2022
@the-frey
Revert "Revert "Merge pull request #51 from CosmosContracts/dimi/txs-…
e2caa12 
…endpoint" (#147)"

This reverts commit 2476253.
@the-frey the-frey mentioned this pull request Feb 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimiandre dimiandre dimiandre approved these changes

@the-frey the-frey the-frey approved these changes

@faddat faddat Awaiting requested review from faddat

@JakeHartnell JakeHartnell Awaiting requested review from JakeHartnell JakeHartnell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@giansalex @the-frey @dimiandre