✅ remove ignite/starport

[faddat]

The ignite cli has a terrible track record of keeping dependencies like cosmoscmd up to date.

For security reasons, we should remove any depencency that lives in its repository.

For maintainability reasons, same thing.

New plan is to migrate over the cli tests too. I think it's possible that they'll help me to identify the issue.

• removes ignite cli
• bumps to v10
• needed to continue work on:
  • DNM: 46 #230
  • Upgrade to SDK 46 #232
  • Tracking issue for V10 #235
  • Add liquid staking module (discussion) #234

[faddat]

Note:

I can't figure out why the docker container keeps failing, causing the CI tests for gov (which we want to keep) are failing.

Do we happen to use the ignite cli at all in the flow?

[sascha1337]

Note:

I can't figure out why the docker container keeps failing, causing the CI tests for gov (which we want to keep) are failing.

Do we happen to use the ignite cli at all in the flow?

Without testing it on my end, i guess it's failing due to some incorrect working directory at the runtime execution - i did a quick scroll thru the workflow log ~ and i think i saw that the chronologic order of the gh actions might be incorrect.

The logfile tells us that the docker compose up command is running against the wall - this action is being executed AFTER cloning cw-unity-prop repo, which does not have a docker compose file. That should be ran on the juno(d) workdir, not cw unity prop.

Maybe.

[faddat]

Thank you very much for your review, that is actually a bug that I introduced while testing CI, and I will revert it shortly.

Sorry about that!

[the-frey]

Ok:

• Main needs merging in
• May as well change v8 -> v9 since we're now working against v9 candidate

And then I think I'm happy with merging this and moving it forward for testing.

[sascha1337]

Gonna do that now out of curiosity

[faddat]

on it.

[faddat]

@the-frey hey, main is merged in already afaik

@sascha1337 if you're working on juno routinely, please feel free / encouraged to make PR's into branches like these, basically to keep up velocity.

[the-frey]

LGTM. Will also tag this with a pre-release once it's on main so I can run a bunch of local checks against the binary etc

[sascha1337]

@the-frey hey, main is merged in already afaik

@sascha1337 if you're working on juno routinely, please feel free / encouraged to make PR's into branches like these, basically to keep up velocity.

I've literally seen that on the iOS app I had to turn on notifications manually, now I see what's going on when watching repos :) automatically being in the feedback loop

Plus whitelisting GitHub notifications when turning on do not disturb / work modus across devices, small thing but literally game changer 😁 LGTMFAM

[the-frey]

@faddat Is this now updated and R4M? I've already approved but I think GH is prompting me to smash that tick button again.

[faddat]

Yep, this is ready to rock.

[the-frey]

@joeabbey would you mind giving this a review dude?

[the-frey]

Spotted maybe 1 thing that might be worth renaming, but GTM apart from that (and apols if I've mis-remembered where the app info via CLI gets logged from - the Stargate Cosmos App thing rather than a configurable app name always annoyed me).

[faddat]

they're both worth changing. thanks.

[the-frey]

Have changed. If CI passes then it's GTM

[the-frey]

LGTM