Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete gosec.yml #256

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Delete gosec.yml #256

merged 2 commits into from
Aug 10, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 7, 2022 •
edited

Gosec is replaced in two places:

  • golangci-lint
  • codeql

Notes:

  • can no longer pull the informal modified gosec docker container
  • should merge Use golangci-lint #243
  • This is a priority item because it makes all other PR's fail and we want for the green checkmark to be meaningful

Merge order:

  1. merge this
  2. merge Use golangci-lint #243
  3. merge the other dependabot pr's I approved

@faddat
Delete gosec.yml
8fc5e30 
Gosec is replaced in two places:

* golangci-lint
* codeql
the-frey
the-frey previously approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@the-frey the-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge if now redundant

@faddat
Copy link
Contributor Author

faddat commented Aug 8, 2022 •
edited

Is redundant.

(key redundancy is codeql which has all the cosmos-sdk goodies in it)

@the-frey the-frey self-requested a review August 8, 2022 15:55
@faddat faddat merged commit 1227fc5 into main Aug 10, 2022
@sascha1337
Copy link

Snyk read only for further static analysis would be neat, if added

@the-frey the-frey deleted the faddat/remove-gosec branch September 17, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeHartnell JakeHartnell JakeHartnell approved these changes

@the-frey the-frey the-frey approved these changes

@joeabbey joeabbey Awaiting requested review from joeabbey

@blockpane blockpane Awaiting requested review from blockpane

@svabhishek svabhishek Awaiting requested review from svabhishek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@faddat @sascha1337 @JakeHartnell @the-frey