Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod #272

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Update go.mod #272

merged 7 commits into from
Aug 24, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 22, 2022

Bump back down to go 1.18

Bump back down to go 1.18
Copy link
Collaborator

@the-frey the-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgraded the dockerfile as well and resolved the errors with superlinter.

@faddat
Copy link
Contributor Author

faddat commented Aug 22, 2022

Personally I would not have downgraded the docker file but no big deal.

I think that we actually want to build using 19, because that's what most developers are going to be using and stuff like that but we can just bump down the required go version.

I should also probably make us our own build container there's really no reason to use anyone else's and well I'll see what I can do with that.

@the-frey
Copy link
Collaborator

Well, the docker container should just use the same version as the go mod (if there's a strong disagreement, then it's easy to change that). Kind of disagree about our own build container, base image plus some steps is... kind of fine tbh?

@faddat
Copy link
Contributor Author

faddat commented Aug 22, 2022

Oh no it's not as strong disagreement at all I think we're all good, I was maybe just musing

@the-frey
Copy link
Collaborator

Cool, let's 🚢 this one then?

@faddat
Copy link
Contributor Author

faddat commented Aug 24, 2022

oh definitely! (just I made the PR, and so cannot approve it)

@dimiandre
Copy link
Member

lgtm

@dimiandre dimiandre merged commit 97a626c into main Aug 24, 2022
@the-frey the-frey deleted the faddat-patch-go18 branch August 25, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants