-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go.mod #272
Update go.mod #272
Conversation
Bump back down to go 1.18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgraded the dockerfile as well and resolved the errors with superlinter.
Personally I would not have downgraded the docker file but no big deal. I think that we actually want to build using 19, because that's what most developers are going to be using and stuff like that but we can just bump down the required go version. I should also probably make us our own build container there's really no reason to use anyone else's and well I'll see what I can do with that. |
Well, the docker container should just use the same version as the go mod (if there's a strong disagreement, then it's easy to change that). Kind of disagree about our own build container, base image plus some steps is... kind of fine tbh? |
Oh no it's not as strong disagreement at all I think we're all good, I was maybe just musing |
Cool, let's 🚢 this one then? |
oh definitely! (just I made the PR, and so cannot approve it) |
lgtm |
Bump back down to go 1.18