Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override cw default compile costs #90

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Conversation

the-frey
Copy link
Collaborator

Addresses #85

I've now checked that the node runs at least but will run some more checks over the weekend.

The bash scripts I'm now using to bootstrap the app in dev are pretty useful so I've committed and documented them because tbh people have been asking on discord & it's on my to-do list to improve the dev section of the docs.

Probably could use a once-over for sanity-checking before I spam a bunch of contracts at it.

Once we're happy with code integrity here and want to merge, there's the question of what to actually change the value to. I assume we'll want to raise it a bit more than what I've done here and run some tests on uni? @JakeHartnell - thoughts?

Copy link
Contributor

@JakeHartnell JakeHartnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yolo.

@JakeHartnell
Copy link
Contributor

Build and Deploy is failing because of this dumb file: https://github.com/CosmosContracts/juno/blob/main/.github/workflows/pages.yml

I vote we remove it as we're not really using the Starport vue stuff. 🤷

app/wasm_config.go Outdated Show resolved Hide resolved
app/wasm_config.go Outdated Show resolved Hide resolved
app/wasm_config.go Outdated Show resolved Hide resolved
@faddat
Copy link
Contributor

faddat commented Nov 20, 2021

Agree about YOLO make it ten.

expensive is good.

@the-frey the-frey marked this pull request as ready for review November 21, 2021 17:20
@the-frey
Copy link
Collaborator Author

the-frey commented Nov 21, 2021

I think as mentioned on TG that if this were tagged up as v2.0.0-beta.1, I can use this as the target binary for the instructions for the moneta-beta upgrade handler, meaning it doesn't need its own upgrade handler. Otherwise would maybe need one as iirc these param changes are consensus-breaking.

@the-frey
Copy link
Collaborator Author

@faddat / @giansalex happy for these changes to go in?

@giansalex
Copy link
Member

@the-frey yes, must be included in moneta-beta upgrade

@dimiandre
Copy link
Member

Looks good to me!

Can these params be modified by governance?

@the-frey
Copy link
Collaborator Author

@dimiandre I think we could make them modifiable by governance in future, but for the moment they have to be changed in our codebase.

@the-frey the-frey merged commit 5232cec into main Nov 23, 2021
@the-frey the-frey deleted the override_cw_default_compile_costs branch November 23, 2021 09:17
@giansalex giansalex mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants