Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

juno v22 with ecosystem updates #994

Merged
merged 12 commits into from
Apr 21, 2024

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 11, 2024

This PR updates the juno v22 release so that it uses fresh cosmos ecosystem libraries.

  • comet will have the latest improvements
  • cosmos-sdk will be updated to solve a security issue
  • latest math and errors libraries will be used

Don't make new releases without applying the latest patches.

Process: visit the repository of each dependency and check to see if Juno is using the latest version of the dependency in question.

Using the latest version of Go makes it impossible for the validator set to have mixed runtimes.

@faddat
Copy link
Contributor Author

faddat commented Apr 11, 2024

I have no idea how to fix these "login denied" things tho. good luck. Should move hosting of images and stuff off of heighliner and onto ghcr.io

@dimiandre
Copy link
Member

dimiandre commented Apr 11, 2024

something changed in app.toml?

9:01AM ERR failure when running app err="failed to parse /var/cosmos-chain/juno/config/app.toml: '' expected a map, got 'interface'"

@faddat
Copy link
Contributor Author

faddat commented Apr 16, 2024

Maybe. Just, it seems to break only one thing, interchaintest.

Would be nice to be able to keep Juno up to date. Check the changelogs for the things that I bumped in addition to the things you bumped. The fixes are nontrivial.

Recommend that you review my changes once again, and ask yourself:

  • should this break ict?
  • does this break ict?

@dimiandre
Copy link
Member

dimiandre commented Apr 17, 2024

Maybe. Just, it seems to break only one thing, interchaintest.

Would be nice to be able to keep Juno up to date. Check the changelogs for the things that I bumped in addition to the things you bumped. The fixes are nontrivial.

Recommend that you review my changes once again, and ask yourself:

  • should this break ict?
  • does this break ict?

It's not only interchain test, this PR breaks juno init on standard builds, docker and anywhere else.

git clone 
make install

rm -rf ~/.juno

junod init moniker --chain-id test

11:52AM ERR failure when running app err="failed to parse /Users/dimi/.juno/config/app.toml: '' expected a map, got 'interface'"

I'm on it, next time would be better to do complete PRs not just version bumps without even checking if node starts after it

edit: it's viper. 1.18 doesn't work with sdk 47.10 InterceptConfigsPreRunHandler

@Reecepbcups
Copy link
Contributor

Reecepbcups commented Apr 18, 2024

edit: it's viper. 1.18 doesn't work with sdk 47.10 InterceptConfigsPreRunHandler

Correct, it's an SDK issue. This fixes the SDK incompatibility with any network (47 & 50)

// breaks SDK app.toml parsing in ictest.
replace github.com/spf13/viper => github.com/spf13/viper v1.17.0

// also required due to an incorrect tag upstream if not already
replace cosmossdk.io/core => cosmossdk.io/core v0.11.0

@faddat
Copy link
Contributor Author

faddat commented Apr 19, 2024

@dimiandre
Copy link
Member

viper issue seems to be fixed with sdk v0.47.11

since jacob already bumped it i'll merge this PR. We'll have to bump it again once the v0.47.11 release is officially out

thanks all!

@dimiandre dimiandre merged commit b0faafb into CosmosContracts:dimi/v22 Apr 21, 2024
18 of 20 checks passed
dimiandre added a commit that referenced this pull request Apr 21, 2024
* version bumps

* enable unsafe cors on docker by default

* preprare v22 release

* empty v22 upgrade handler

* version bumps on interchaintest

* lint

* more lint

* use cometbft v0.37.2 on interchain test

* tokenfactory updates

* juno v22 with ecosystem updates (#994)

* update the juno update

* tidy ict

* remove toolchain line

* bump go

* bump cometbft-db

* update pfm and ibc-hooks

* tidy interchaintest

* lock exp in interchaintest

* bump cometbft-db

* tidy

* tidy ict

---------

Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants