Cosmos Audio Infrastructure (CAI) #2318
Conversation
These files will be replaced with the new Cosmos Audio Infrastructure (CAI).
The Cosmos Audio Infrastructure (CAI) helps with audio-related operations and with interfacing to audio devices at a low-level.
The AC97 is an audio codec standard developed by Intel Architecture Labs. The standard is used in motherboards, modems, and sound cards, and allows for sound cards to share a common architecture. This commit also modifies the PIC to allow for IRQ 11.
|
This is a really interesting pr, but the problem is that in virtualbox the VFS doesnt work, and so we cant really use virtual box when we use the vfs, maybe ill try to give a preformatted vmdk file for virtualbox when I get home. |
There may be a way to get AC97 support in VMWare using the |
This could maybe help you https://kb.vmware.com/s/article/2010400 |
|
It looks like that while the ES1371 is a AC97-compatible sound card, it still defines its own method to set it up.... This explains why the AC97 driver does detect the sound card, but it doesn't want to perform a PCM Out reset. For example, the AC97 spec defines a buffer descriptor list, while the ES1371 uses a single buffer. I feel like this will require another driver class :/ For now, the driver works fine on virtualizers/emulators that define a fully-compatible AC97 sound card (like QEMU and VBox) |
There was a problem hiding this comment.
Thanks for the great PR! Overall the code looks very good with just a few tiny changes required. I already added a few questions/comments but will need to look through it again.
Could you please add some documentation for both users to use it and other developers to better understand the design approach? I think it would also be good to add a few tests to ensure that the code does not break.
Enables unsafe code in all configurations when compiling the Cosmos.HAL2 project.
This commit allows the kernel to change the buffer size of an AC97-compatible sound card while it is running.
Slight AudioMixer clean-up: this commit makes the syntax cleaner, and removes an obsolete constructor created for an older version of the class when it was still in development. The removed constructor is not needed, as AudioMixer automatically creates its buffers to compensate for any buffers that will be written to.
This commit implements a poll limit for the AC97 driver when a reset request is performed. AC97-compatible sound cards that have a different set-up routine, i.e. Ensoniq AudioPCI, will not respond to such requests.
if you have any questions, feel free to contact me at Discord: ascpixi#8013 i'll be happy to help with any questions :)
thank you github markdown
i forgor 💀 to proof-read it
|
How do I use the example? I got 13 errors when I first opened the project :( |
Right now, the CAI isn't merged into Cosmos - if you're using the devkit built using this branch and you're experiencing problems, please post the errors you get here |
|
SB16 in Cosmos, next up, DOOM! |
So the only thing to change is adding brackets to all ifs and all public fields should be PascalCase, right? |
This member will probably never be used, as an audio mixer shouldn't really have a "position" property.
Changes: - public field names changed to PascalCase - added braces to all "if" statements
There was a problem hiding this comment.
Really great work thanks for your contribution, it looks fine to me. Plus since the AC97 card supports MSI it will be really helpful to test interrupts for PCI devices using APIC.
Edit: @quajak is it okay for you to have unsafe code under Cosmos.HAL2?
Sometimes, .WAV files can contain extra information by encoders. This is de facto obsolete, and no modern encoder uses any extra fields in the header, however, older encoders can introduce such headers. This commit will skip such extra information. An example of a file with a non-standard field attached at the end: https://cdn.discordapp.com/attachments/833978908189392916/994710945337188472/out_of_gum_x.wav
|
Some minor adjustments, I feel like it's ready to be merged now! |
|
@valentinbreiz Good point, I think its fine with unsafe code in HAL. IMO The code definitely belongs in HAL. Not using pointers is slower and I think speed is quite important for CAI. Rewriting it all to use Spans would maybe work 🤷 but simply using pointers if fine for me. |
This pull request implements an audio infrastructure that helps with audio-related operations and interfacing with audio devices at a low-level. An AC97 driver is included.
The following features can be implemented in future pull requests:
The AC97 driver is not supported by VMWare, as it does not feature emulation for any fully-compatible AC97 devices. It's recommended to use CAI with emulators/virtualizers such as QEMU or VirtualBox.
TODO:
You can download a demo kernel solution by clicking here.