fix acpi tables being overwritten #2550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02fa8c6.
|
hmm, why appveyor test doesnt start? |
Because you aren't pushing to the main branch |
|
oh okay |
|
Thanks for the fix it could be merged if working but it's a tricky way to work around the bug... the actual reason why ACPI tables can be overwritten is because the multiboot2 memory map is kind of broken (and it contains the ACPI table address) |
|
oh when i run it in appveyor kernel crashes after ps/2 controller initialization |
Update Makefile
Implement System.Threading.Timer
disable notifications Webhook
Implement MathF
'Implement' mouse delta values & minor refactoring.
fix make file
Update appveyor.yml
|
okay, this wont work. if someone has time, please fix this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should work but i didnt test yet and dont now how. well i fixed acpi table overlapping by making memory allocator to not allocate "unusable" addresses. push to feature/apic.
fixes #2546