-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/add-supporting-file-resiliency #187
Merged
evamaxfield
merged 12 commits into
main
from
liamphmurphy-feature/check-matterfile-urls
May 22, 2022
Merged
feature/add-supporting-file-resiliency #187
evamaxfield
merged 12 commits into
main
from
liamphmurphy-feature/check-matterfile-urls
May 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 94.55% 94.56% +0.01%
==========================================
Files 50 50
Lines 2607 2615 +8
==========================================
+ Hits 2465 2473 +8
Misses 142 142
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
event gather pipeline
A feature or bugfix relating to event processing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #179
Original PR: #186
Description of Changes
This PR adds a try_url call for the supporting_file.uri used before the creation / upload of a matter file (the try is done before these actions occur). If a LookupError is thrown, then perform a usual log.
@liamphmurphy only change I made from your PR was mocking the
try_url
function instead ofresource_exists
and I think the big mistake was actually that the pipeline.run wasn't within the context of the mocked function.