Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-supporting-file-resiliency #187

Merged
merged 12 commits into from
May 22, 2022

Conversation

evamaxfield
Copy link
Member

Link to Relevant Issue

This pull request resolves #179

Original PR: #186

Description of Changes

This PR adds a try_url call for the supporting_file.uri used before the creation / upload of a matter file (the try is done before these actions occur). If a LookupError is thrown, then perform a usual log.

@liamphmurphy only change I made from your PR was mocking the try_url function instead of resource_exists and I think the big mistake was actually that the pipeline.run wasn't within the context of the mocked function.

@evamaxfield evamaxfield self-assigned this May 22, 2022
@evamaxfield evamaxfield added enhancement New feature or request event gather pipeline A feature or bugfix relating to event processing labels May 22, 2022
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #187 (1c249e4) into main (5888bca) will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   94.55%   94.56%   +0.01%     
==========================================
  Files          50       50              
  Lines        2607     2615       +8     
==========================================
+ Hits         2465     2473       +8     
  Misses        142      142              
Impacted Files Coverage Δ
cdp_backend/pipeline/event_gather_pipeline.py 85.92% <85.71%> (+0.21%) ⬆️
...ckend/tests/pipeline/test_event_gather_pipeline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5888bca...1c249e4. Read the comment docs.

@evamaxfield evamaxfield merged commit adb41fa into main May 22, 2022
@evamaxfield evamaxfield deleted the liamphmurphy-feature/check-matterfile-urls branch May 22, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request event gather pipeline A feature or bugfix relating to event processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try URL before creating / uploading Matterfile
2 participants