fix/odd-spacing-in-content-of-filter-popup #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves some odd spacing in the sorting algo selection UI on the search results page.
Description of Changes
The Mozilla protocol class for forms, fieldsets, and mzp-c-choices have margins and/or padding that creates extra whitespace below the list of sorting options. I created a styled component that sets the margin and/or padding to 0.
There is also extra whitespace to the right of the sorting options. I removed the min-width on the popup and let its content determine its width. Moved the min-width style to the button container so that there is some space between the buttons (in the other filters).
Screenshots