Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/center-search-bar-in-homepage #145

Merged
merged 1 commit into from
Dec 16, 2021
Merged

fix/center-search-bar-in-homepage #145

merged 1 commit into from
Dec 16, 2021

Conversation

tohuynh
Copy link
Collaborator

@tohuynh tohuynh commented Dec 16, 2021

Link to Relevant Issue

This pull request resolves #130

Description of Changes

Just vertically centering the search bar on the home page.

Screenshot

image

@tohuynh tohuynh self-assigned this Dec 16, 2021
evamaxfield
evamaxfield approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I am fine with this. It may be good to add a bit more content to the page. Just like "most recent event" and "most recent matter" or something when that is done?

@tohuynh
Copy link
Collaborator Author

tohuynh commented Dec 16, 2021

I think I am fine with this. It may be good to add a bit more content to the page. Just like "most recent event" and "most recent matter" or something when that is done?

When "most recent X" gets added the search bar wouldn't be centered anymore?

@evamaxfield
Copy link
Member

I think I am fine with this. It may be good to add a bit more content to the page. Just like "most recent event" and "most recent matter" or something when that is done?

When "most recent X" gets added the search bar wouldn't be centered anymore?

I really have no idea. Landing pages are hard.

@tohuynh
Copy link
Collaborator Author

tohuynh commented Dec 16, 2021

I really have no idea. Landing pages are hard.

OK, let's add this PR for now. I think the home page looks a little bit better for now (without the "most recent X").

@evamaxfield
Copy link
Member

I really have no idea. Landing pages are hard.

OK, let's add this PR for now. I think the home page looks a little bit better for now (without the "most recent X").

Agree. Feel free to merge.

@tohuynh tohuynh merged commit 03c6477 into CouncilDataProject:main Dec 16, 2021
@tohuynh tohuynh deleted the fix/center-search-bar branch December 17, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evamaxfield evamaxfield evamaxfield approved these changes

Assignees

@tohuynh tohuynh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertically center the search bar in the landing page
2 participants
@tohuynh @evamaxfield