Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/minutes-item-expansion #146

Merged
merged 2 commits into from
Dec 17, 2021
Merged

fix/minutes-item-expansion #146

merged 2 commits into from
Dec 17, 2021

Conversation

tohuynh
Copy link
Collaborator

@tohuynh tohuynh commented Dec 17, 2021

Link to Relevant Issue

This pull request resolves #126

Description of Changes

  • Bold the minutes item's name to distinguish it from minutes item's description
  • Add the minutes item's description
  • "See documents" color is dark blue
  • Remove the triangle marker (arrow right) from "See documents"
  • Place the +/- icon immediately after "see documents" and make it all one line.
  • Place the attachment links in <ul> to add indentation from the minutes item's name and description
  • The attachment URL open in a new tab

Screenshot

image

@tohuynh tohuynh self-assigned this Dec 17, 2021
evamaxfield
evamaxfield approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks! Merge whenever!

@tohuynh tohuynh merged commit 955cc78 into CouncilDataProject:main Dec 17, 2021
@tohuynh tohuynh deleted the fix/attachment-links branch December 18, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evamaxfield evamaxfield evamaxfield approved these changes

Assignees

@tohuynh tohuynh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minutes Item expansion cleanup
2 participants
@tohuynh @evamaxfield