feature/share-event-page #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evamaxfield
approved these changes
Dec 29, 2021
src/pages/EventPage/EventPage.tsx
Outdated
Comment on lines
50
to
56
| return [s, t].map((el) => { | ||
| if (el !== null && typeof el === "string") { | ||
| const n = parseFloat(el); | ||
| return isNaN(n) ? 0 : n; | ||
| } else { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
My only question for the whole pull request is "what happens if someone shares url?s=1 will that route to session 1 and default to 0 seconds? AND vice-versa, if someone only shares the seconds url?t=100 will that default to session=0?
I think this is the code block that does that but just want to make sure.
There was a problem hiding this comment.
shares url?s=1 will that route to session 1 and default to 0 seconds?
Yes, but s=1 will route to the second session (s starts at 0).
shares the seconds url?t=100 will that default to session=0?
Yes
This only happens if the user alters the shareable URL though. The generated shareable URL will contain s and t (if start at checkbox is checked and t>0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #95
Description of Changes
Add a share button to generate a shareable URL for an event, with optional query parameters for the current session and user-selected timepoint.
This is mostly a copy of the original functionality with some changes to make it type-safe and add the current session to the shareable URL.
Screenshots
(share button)
(modal)
