Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/share-event-page-modal-sizing #181

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

tohuynh
Copy link
Collaborator

@tohuynh tohuynh commented Jan 19, 2022

Link to Relevant Issue

This pull request resolves #

Description of Changes

Include a description of the proposed changes.
#177 introduced a wildcard rule

* {
  box-sizing: initial;
}

that caused the share event page modal body to have unaligned widths

image

This PR just removes the wildcard box-sizing rule to the navigation element in the header so the header element still has the same size as the org website.

Link to Forked Storybook Site

If component changes (especially visual changes) are contained in this PR, we ask that you provide a link to a publicly viewable version of the Storybook docs site, so PR reviewers can see your changes without having to install and view your code locally.

Please see CONTRIBUTING.md for directions on how this can be done.

image

@tohuynh tohuynh self-assigned this Jan 19, 2022
@tohuynh tohuynh merged commit d306868 into CouncilDataProject:main Jan 19, 2022
@tohuynh tohuynh deleted the fix/share-event-page-modal branch January 20, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants