component/legislation-introduction #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohuynh
approved these changes
Feb 8, 2022
Comment on lines
18
to
19
| <b className="mzp-u-body-sm">{matterStatus.matter?.title}</b> | ||
| <div |
There was a problem hiding this comment.
I don't think mzp-u-body-sm is valid Mozilla protocol CSS class
There was a problem hiding this comment.
where can I find a list of valid classes? I use their website but in a case like this where I want something that's just a little bit different from the listed items, it becomes very difficult to figure out what is valid and what is not.
There was a problem hiding this comment.
Not sure if there's a page that lists them. I didn't find the class inside node_modules/@mozilla-protocol/core/css
There was a problem hiding this comment.
https://protocol.mozilla.org/docs/naming.html
Here's how they name their class though
evamaxfield
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #172
Storybook
See the component [here](https://brianl3.github.io/cdp-frontend/?path=/story/library-details-legislation-introduction--approval-story