Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/tab-rename #215

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix/tab-rename #215

merged 1 commit into from
Apr 6, 2022

Conversation

nathankim137311
Copy link
Collaborator

Link to Relevant Issue

This pull request resolves #125

Description of Changes

Changed 'Agenda' to 'Minutes'

Link to Example App

gh-page

@BrianL3 BrianL3 requested review from BrianL3 and tohuynh April 1, 2022 19:54
evamaxfield
evamaxfield approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo! Looks good to me! Thanks for fixing!

@evamaxfield
Copy link
Member

I will let @BrianL3 review and merge since I believe you two were pair programming

tohuynh
tohuynh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@tohuynh tohuynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good.

If we don't use strings.agenda anymore, could we remove it from LocalizedStrings.tsx, en.ts, es.ts, and de.ts?

@BrianL3
Copy link
Collaborator

BrianL3 commented Apr 1, 2022

Shoot, we should remove the unused strings (from LocalizedStrings master list, and the language files).

@evamaxfield
Copy link
Member

I am going to merge this because I think leaving the strings is fine. We will likely find a place to use them again in the future imo.

@evamaxfield
Copy link
Member

Thanks again for the first contribution @nathankim137311 !!

@evamaxfield evamaxfield merged commit 0811260 into CouncilDataProject:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianL3 BrianL3 BrianL3 approved these changes

@evamaxfield evamaxfield evamaxfield approved these changes

@tohuynh tohuynh tohuynh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Agenda" tab should be renamed to "Minutes"
4 participants
@nathankim137311 @evamaxfield @BrianL3 @tohuynh