Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logname=>whoami #294

Closed
wants to merge 1 commit into from
Closed

Conversation

unsystemizer
Copy link
Contributor

I haven't verified the solution, but logname doesn't work for some (it seems when the installer executed from a X-Windows terminal, while running from "pure" shell does work).
Ref:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1537645
and
https://counterpartytalk.org/t/fednode-install-error/2350

I haven't verified the solution, but logname doesn't work for some (it seems when the installer executed from a X-Windows terminal, while running from "pure" shell does work).
Ref:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1537645
and 
https://counterpartytalk.org/t/fednode-install-error/2350
@unsystemizer
Copy link
Contributor Author

unsystemizer commented Sep 9, 2017

I still get this with Ubuntu 16.04 when doing install remotely via SSH. Can this be merged?

ubuntu@fednode:~/federatednode$ /usr/bin/logname
/usr/bin/logname: no login name

@deweller
Copy link
Contributor

These are similar but not equivalent commands.

logname prints the name of the logged in user, whoami gives the name of the user attached to the current process.

bash$ su
Password: ......

bash# whoami
root
bash# logname
bozo

A better approach would be to test for logname in fednode.py and throw a specific error if is missing.

unsystemizer added a commit to CounterpartyXCP/Documentation that referenced this pull request Oct 26, 2017
@unsystemizer
Copy link
Contributor Author

https://github.com/CounterpartyXCP/federatednode/blob/2.2.3/fednode.py#L152 makes sure the user isn't "root". I changed the document and asked users to install coreutils so no changes are required in the code.

@unsystemizer unsystemizer deleted the patch-1 branch October 26, 2017 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants