-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS test fixes and other patches #224
Conversation
NSString *key = [command objectAtIndex:i]; | ||
NSString *valueString = [command objectAtIndex:i + 1]; | ||
// Convert value string to integer | ||
NSNumber *value = @([valueString intValue]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why we are converting string value to integer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i got my answer from flutter code :)
@@ -689,7 +689,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result | |||
NSString *key = [command objectAtIndex:0]; | |||
NSString *value = [command objectAtIndex:1]; | |||
|
|||
[Countly.user push:key value:value]; | |||
[Countly.user pull:key value:value]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch 👍
view = eventList[4]; | ||
expect(view['key'], '[CLY]_view'); | ||
expect(view['segmentation']['segment'], Platform.isIOS ? 'iOS' : 'Android'); | ||
expect(view['segmentation']['name'], 'hawk'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
View name is truncated, so it should be 'hawk'.substring(0, MAX_VALUE_SIZE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh this is value limit test. those are truncated at key limit
No description provided.