Merge pull request #486 from Countly/tc-widget-support

[Feedback Widgets] Terms and conditions support
Countly · Apr 23, 2024 · b2e3a90 · b2e3a90
2 parents 53998e5 + 5523a95
commit b2e3a90
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 24.4.0
+- Added support for Feedback Widget terms and conditions
+
 ## 23.12.6
 - Mitigated an issue where error tracking could prevent SDK initialization in async mode
 

diff --git a/examples/create_examples.py b/examples/create_examples.py
@@ -23,7 +23,7 @@ def setup_react_example():
 
 def setup_angular_example():
     print("Creating Angular example...")
-    os.system("npx @angular/cli new angular-example --defaults")
+    os.system("npx @angular/cli@next new angular-example --defaults")
 
     # Copy contents of Angular folder over to Angular example
     shutil.copytree("Angular", "angular-example/src", dirs_exist_ok=True)

diff --git a/lib/countly.js b/lib/countly.js
@@ -3723,11 +3723,12 @@
                 url += "&platform=" + this.platform;
                 url += "&app_version=" + this.app_version;
                 url += "&sdk_version=" + sdkVersion;
+                var customObjectToSendWithTheWidget = {};
+                customObjectToSendWithTheWidget.tc = 1; // indicates SDK supports opening links from the widget in a new tab
                 if (feedbackWidgetSegmentation) {
-                    var customObjectToSendWithTheWidget = {};
                     customObjectToSendWithTheWidget.sg = feedbackWidgetSegmentation;
-                    url += "&custom=" + JSON.stringify(customObjectToSendWithTheWidget);
                 }
+                url += "&custom=" + JSON.stringify(customObjectToSendWithTheWidget);
                 // Origin is passed to the popup so that it passes it back in the postMessage event
                 // Only web SDK passes origin and web
                 url += "&origin=" + passedOrigin;