Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/keep stats but remove user #105

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Conversation

ajeanneney
Copy link
Collaborator

Issue description :

Delete only treatmentSumary and not all statistics on purge

Describe your changes :

Unset treatmentsumary instead of deleting statistic.

How to test :

insert statistics and run purgeDb script
Waring : if the user mentioned in the treatment sumary is not found in database the search for specific statistic failed

Checklist before requesting a review

  • I have performed a self-review of my code.
  • The feature works locally.
  • If it's relevant I added tests.
  • Will this be part of a product update? If yes, please write one phrase about this update.

Copy link
Collaborator

@Bouba-cassation Bouba-cassation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai lancé la branche en local et tester.

  • Tout est bon, quand on supprime un treatmentsSummary (set : []), les stats sont toujours affichées, par contre nous n'avons plus le traimentment duration du document.

Copy link
Collaborator

@Bouba-cassation Bouba-cassation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai testé en local en :

  • Updatant le treatmentDate puis lancer le script purgeDb.js dans l'intervale (--beforeMonths 1). Ca supprime l'utilisateur et laisse le treatmentDuration.

@ajeanneney ajeanneney merged commit 5ac69f1 into dev Jun 21, 2024
1 check passed
@ajeanneney ajeanneney deleted the feat/keep-stats-but-remove-user branch June 21, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants