Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG_SP] symmetric lane change setting is not working #2889

Closed
WeAreV3N0M opened this issue Oct 23, 2023 · 7 comments · Fixed by #2904
Closed

[BUG_SP] symmetric lane change setting is not working #2889

WeAreV3N0M opened this issue Oct 23, 2023 · 7 comments · Fixed by #2904
Assignees
@pvaiko
Labels
bug Something isn't working
Milestone
7.3.1.4

Comments

@WeAreV3N0M
Copy link
Contributor

READ FIRST
https://github.com/Courseplay/Courseplay_FS22/wiki

Steps to reproduce
Unknown reason behind bug so not sure how to reproduce

Actual behavior
I have accepted a cotton harvesting job with two Case IH Module Express 635 harvesters (base game) And loaded a previously generated course that was generated for two machines. After the harvesters reached the end of first row (not counting headlands) both machines changed to the other side of the path for the next row. They turned from left side to right in next row and from right side to left. I tested it with symmetrical lane change turned on and turned off, it seemed to have no effect at all.

Expected behavior
With symmetrical lane change turned on, the machines should remain on the same side of the path all the way to the end. If started on the left side, after turning the worker should continue on left side.

Courseplay version
Version used: 7.3.1.3

Log
Please attach a log with all debug channels active.
For help with the debug channels,
please check out the readme at the github front page.

Map
Elm Creek Edit 4x V1.0.0.9 By Stevie

Vehicles/ implements involved
Case IH Module Express 635
log.txt

Mod yes/no ?
no

Relevant script mods
Mods like Autodrive or VCA and so on.
@WeAreV3N0M WeAreV3N0M added the bug Something isn't working label Oct 23, 2023
@WeAreV3N0M WeAreV3N0M changed the title [BUG_SP] [BUG_SP] Cotton harvester lane changing on dual machine course Oct 23, 2023
@WeAreV3N0M
Copy link
Contributor Author

Just tested it with the John Deere machine. There is no difference between symmetrical lane change turned on or turned off.
log.txt

@Tensuko Tensuko changed the title [BUG_SP] Cotton harvester lane changing on dual machine course [BUG_SP] symetric lane change setting is not working Oct 23, 2023
@Tensuko
Copy link
Contributor

Tensuko commented Oct 23, 2023

It is generally broken somehow.

@WeAreV3N0M
Copy link
Contributor Author

WeAreV3N0M commented Oct 23, 2023 •
edited
Loading

I'm not up to date with this topic. Has it been reported before?
I have used it in earlier versions and it was fine.

@pvaiko pvaiko changed the title [BUG_SP] symetric lane change setting is not working [BUG_SP] symmetric lane change setting is not working Oct 23, 2023
@rohne83
Copy link
Contributor

rohne83 commented Oct 24, 2023 

Expected behavior
With symmetrical lane change turned on, the machines should remain on the same side of the path all the way to the end. If started on the left side, after turning the worker should continue on left side.

Nope, that's the behaviour for default asymmetric lane change, to be used for lands or spirals mode. With symmetric lane change (rather for updown or racetracks) the offset should of course always change at every turn. In my eyes that works as desired.

@JDTiger
Copy link

JDTiger commented Oct 24, 2023 •
edited
Loading

Important addendum I found out:

When switching the lane change and/or Implement raise/lower options you have to reload the course for the change to apply

@WeAreV3N0M
Copy link
Contributor Author

If I set one machine to go on left side and the other machine to the right, and then both try to go on right side (after me triple checking their CP settings are identical) that's everything but desired.
Also not desired if the workers behave the same way with symmetrical lane change turned on or turned off.
Both of the things mentioned above happened during testing and Tensuko saw my log.

@Tensuko
Copy link
Contributor

Tensuko commented Oct 25, 2023

Guys just wait for it.
It was easy confirm and we have a look at it.

@pvaiko pvaiko self-assigned this Oct 26, 2023
pvaiko added a commit that referenced this issue Oct 27, 2023
@pvaiko
fix: symmetric lane change
e51ac2a 
Only reuse a multitool offset course if all
parameter match.

#2889
@pvaiko pvaiko linked a pull request Oct 27, 2023 that will close this issue
fix: symmetric lane change #2904
Merged
@pvaiko pvaiko mentioned this issue Oct 27, 2023
Merged
@Tensuko Tensuko added this to the 7.3.1.4 milestone Oct 27, 2023
Tensuko added a commit that referenced this issue Oct 27, 2023
@Tensuko
Push Release 7.3.1.4
41019c5 
- Some shovel position fixes and added missing high dump shovels to vehicle config.
- fix for #2865
- fix for #2889
- Added fruit type check for mission and season. #2885 #2891
- Increased silo area to avoid hitting the walls.
- Translations fixes (our script failed so we had to redo some translations).
- Unloading combine improvements. #2884
- Separated the offset and renamed it to be more clear what it does.
- Can now use a truck + trailer to unload.

We will not add a 2 trailer support to our combine unloading, because it would be impossible to do reverse driving, wich is highly important for our combine unload mode. What does work now is a truck with a fixed or attachable loading area alone or with an additional trailer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvaiko pvaiko

Labels
bug Something isn't working
Projects
None yet
Milestone
7.3.1.4
Development

Successfully merging a pull request may close this issue.

fix: symmetric lane change Courseplay/Courseplay_FS22
5 participants
@pvaiko @JDTiger @Tensuko @WeAreV3N0M @rohne83