Add inline PNG support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
After commit 0d3951e the included example now creates PDF's that validate against this online service: Both when using |
grewn0uille
requested changes
Feb 16, 2024
|
Thanks for the review! I'll update the patch soon! |
|
Thanks for the elaborate review! It's my first work involving PDFs, so I'm still learning, and I'm grateful for your patience and advice! 😄 |
|
I've implemented all the suggestions and updated the branch. |
This fixes this warning: An EOD code was missing in an ASCII85 stream. The operator has an invalid number of operands. The document does not conform to the requested standard.
…rtBouillon#19 Suggested by Lucie Anglade.
Suggested by Lucie Anglade.
CourtBouillon#19 Suggested by Lucie Anglade.
Suggested by Lucie Anglade.
Suggested by Lucie Anglade.
|
I've just fixed the merge conflicts. |
|
Looks good for me! Thanks :) |
liZe
requested review from
grewn0uille and
liZe
and removed request for
grewn0uille and
liZe
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
liZe
requested review from
liZe and
grewn0uille
and removed request for
grewn0uille and
liZe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This patch tries to add inline PNG support. See issue #19.
My apologies for sending this pull request again, but I had not created a separate branch for this
change.
With friendly regards,
Takis