Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#242] use HTTPS #254

Merged
merged 1 commit into from
Aug 5, 2020
Merged

[#242] use HTTPS #254

merged 1 commit into from
Aug 5, 2020

Conversation

webmaster777
Copy link
Contributor

see #242

@mnapoli
Copy link
Member

mnapoli commented May 19, 2020

Thank you, but it looks like you did a full search+replace. Some links are broken, I cannot merge this blindly.

@webmaster777
Copy link
Contributor Author

webmaster777 commented May 19, 2020 •
edited
Loading

I've tried to check all the links I've replaced to see if they still work. Do you have an example of a broken link?

@webmaster777
Copy link
Contributor Author

Ah i see. I Think I found where I started speed-reviewing my changes: e.g. website/home-portfolio.twig

@mnapoli
Copy link
Member

mnapoli commented Aug 5, 2020

Let's move forward, thanks for the PR!

@mnapoli mnapoli merged commit 08c1996 into CouscousPHP:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@webmaster777 @mnapoli