Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use Symfony 5 components #257

Merged
merged 1 commit into from Sep 18, 2020
Merged

Conversation

Baptouuuu
Copy link
Contributor

Problem

I tried to install couscous/couscous as a global dependency on my machine but it failed as I have other tools that rely on Symfony 5 but Couscous only allow Symfony 3 and 4.

Solution

I've added |~5.0 to the version constraints of Symfony packages. As far I've seen there's no strict requirements that prevent to use this version of the packages.

Comments

  • I've only reviewed the code online so I hope the tests cover enough of the code base to catch possible errors. If not so, I'll checkout the project on my machine to check for incompatibilities
  • Would it be interesting to update the code base to use PHP 7.1 type system and add Psalm to ease future upgrades ?

@mnapoli
Copy link
Member

mnapoli commented Sep 18, 2020

Would it be interesting to update the code base to use PHP 7.1 type system and add Psalm to ease future upgrades ?

Yes! 7.1 seems definitely reasonable.

@mnapoli mnapoli merged commit 8f9066e into CouscousPHP:master Sep 18, 2020
@Baptouuuu Baptouuuu deleted the patch-1 branch September 18, 2020 12:46
@Baptouuuu Baptouuuu mentioned this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants