Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #55 and code refactoring #58

Merged
merged 4 commits into from
Dec 11, 2014
Merged

Fixes #55 and code refactoring #58

merged 4 commits into from
Dec 11, 2014

Conversation

mnapoli
Copy link
Member

@mnapoli mnapoli commented Dec 9, 2014

master: Scrutinizer Code Quality Code Coverage
branch: Scrutinizer Code Quality Code Coverage

  • refactoring: separated the InitTemplate step into FetchRemoteTemplate and ValidateTemplateDirectory
  • fixed Speed up external templates #55: in preview, avoid cloning remote repositories on every refresh

Before merging I want to wait for #57 to be able to unit test FetchRemoteTemplate (which right now does git clone so it's hard to unit test).

@mnapoli mnapoli added this to the 1.1 milestone Dec 11, 2014
@mnapoli
Copy link
Member Author

mnapoli commented Dec 11, 2014

Cool, +8% code coverage

mnapoli added a commit that referenced this pull request Dec 11, 2014
@mnapoli mnapoli merged commit ec574b5 into master Dec 11, 2014
@mnapoli mnapoli deleted the remote-templates branch December 11, 2014 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up external templates
1 participant