-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate HTML IDs for headers #93
Conversation
I think better I create another step for that... |
Done. |
I understand your point, but to be honest I always think that done is better than perfect once you don't make things with high coupling and don't violate the SRP and OCP should be easy to change in the future. Thank you very much for your feedback and tell me if I can help you in anything. |
Hey sorry I didn't answer sooner, spent 1 week in the nature, almost completely wireless :p
Yeah you are right. To be honest with my POV too, I was more thinking like "I'm not sure I want to do with a half solution in the meantime" ("half" because I have bigger plans beyond this feature) because we need to make sure it's tested correctly, documented, explained in the changelog and then supported, keep BC, etc... But again, you are right, better working than perfect as long as the code can be easily be swapped out later. So I'd happily merge it if you still have the branch somewhere :) Markua doesn't seem to be moving a lot unfortunately :( I don't especially plan on waiting for it, but lately I have little time so I try to focus it on maintaining stuff I should :p (so much is piling up with a week away already -_-) If you (or someone else) wants to get working on that, I'd be happy to fork the project to the Couscous organization and give you full access on the repo? That would be awesome actually. |
I'm happy you spent some time afk, everybody needs it! I really want to help in spite my time is getting shorter and shorter, so, if you fork the Makua repository, even if you don't give me full access I will send pull requests when I can - actually even if you do I will use pull requests any way, it's better to review my own code before put code into the repository, avoiding to breaking the build and such. I don't have this branch anymore because I usually remove my forks after do what I intent to do, but I can cherry-pick commit 81de352 from your repository. |
This will fix #39 in spite of doesn't use a proper Markdown render.
See the README.md of the functional test.