Delete Secret functionality in Client and Identity (#61)

src/main/python/covata/delta/client.py

@@ -254,6 +254,15 @@ def share_secret(self, identity_id, recipient_id, secret_id):
 
         return self.get_secret(recipient.id, response["id"])
 
+    def delete_secret(self, identity_id, secret_id):
+        """
+        Deletes the secret with the given secret id.
+
+        :param identity_id: the authenticating identity id
+        :param secret_id: the secret id
+        """
+        self.api_client.delete_secret(identity_id, secret_id)
+
 
 class Identity:
     """
@@ -344,6 +353,14 @@ def create_secret(self, content):
         """
         return self.parent.create_secret(self.id, content)
 
+    def delete_secret(self, secret_id):
+        """
+        Deletes the secret with the given secret id.
+
+        :param secret_id: the secret id
+        """
+        self.parent.delete_secret(self.id, secret_id)
+
     def __repr__(self):
         return "{cls}(id={id})" \
             .format(cls=self.__class__.__name__,

src/test/python/test_client.py

@@ -273,3 +273,10 @@ def test_share_secret(client, api_client, key_store, private_key, mock_crypto):
     assert secret.encryption_details.initialisation_vector == mock_crypto["iv"]
     assert secret.encryption_details.symmetric_key == mock_crypto["key"]
     assert secret.base_secret_id == secret_id
+
+
+@pytest.mark.parametrize("identity_id", [None, str(uuid.uuid4())])
+@pytest.mark.parametrize("secret_id", [None, str(uuid.uuid4())])
+def test_delete_secret(client, api_client, identity_id, secret_id):
+    client.delete_secret(identity_id, secret_id)
+    api_client.delete_secret.assert_called_with(identity_id, secret_id)

src/test/python/test_identity.py

@@ -13,6 +13,7 @@
 #   limitations under the License.
 
 import pytest
+import uuid
 from covata.delta import Identity
 
 
@@ -55,9 +56,16 @@ def test_get_identities_by_metadata(identity_a, metadata, page, page_size,
         identity_a.id, metadata, page, page_size)
 
 
-def test_create_secret(identity_a, client):
-    identity_a.create_secret("my secret")
-    client.create_secret.assert_called_with(identity_a.id, "my secret")
+@pytest.mark.parametrize("content", [None, "my secret", b"my secret"])
+def test_create_secret(identity_a, client, content):
+    identity_a.create_secret(content)
+    client.create_secret.assert_called_with(identity_a.id, content)
+
+
+@pytest.mark.parametrize("secret_id", [None, str(uuid.uuid4())])
+def test_delete_secret(identity_a, client, secret_id):
+    identity_a.delete_secret(secret_id)
+    client.delete_secret.assert_called_with(identity_a.id, secret_id)
 
 
 def test_repr(identity_a, identity_b):