Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If smux session dead, cancel the context passed to RPC through Envelope #133

Merged
merged 16 commits into from Dec 13, 2018

Conversation

auxten
Copy link
Contributor

@auxten auxten commented Dec 5, 2018

No description provided.

rpc/codec.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #133 into develop will increase coverage by 0.2%.
The diff coverage is 84.11%.

@@            Coverage Diff             @@
##           develop     #133     +/-   ##
==========================================
+ Coverage    77.47%   77.68%   +0.2%     
==========================================
  Files          142      142             
  Lines        10251    10257      +6     
==========================================
+ Hits          7942     7968     +26     
+ Misses        1684     1671     -13     
+ Partials       625      618      -7

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #133 into develop will increase coverage by 0.54%.
The diff coverage is 78.77%.

@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
+ Coverage    76.97%   77.51%   +0.54%     
===========================================
  Files          137      142       +5     
  Lines        10102    10293     +191     
===========================================
+ Hits          7776     7979     +203     
+ Misses        1704     1682      -22     
- Partials       622      632      +10

@auxten auxten changed the title [WIP]If smux session dead, cancel the context passed to RPC through Envelope If smux session dead, cancel the context passed to RPC through Envelope Dec 12, 2018
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

@leventeliu leventeliu merged commit a3f2374 into develop Dec 13, 2018
@leventeliu leventeliu deleted the feature/cancelQuery branch December 13, 2018 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants