Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build.sh and Makefile #142

Merged
merged 8 commits into from
Dec 21, 2018
Merged

Refactor build.sh and Makefile #142

merged 8 commits into from
Dec 21, 2018

Conversation

laodouya
Copy link
Member

  1. Refactor build.sh and Makefile
  2. Replace running docker image to an embed glibc version of alpine.
  3. Update GNTE submodule: Reduce bench docker image size.

@laodouya laodouya mentioned this pull request Dec 20, 2018
Closed
leventeliu
leventeliu approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@leventeliu leventeliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approve.

xq262144
xq262144 approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@xq262144 xq262144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approve

@xq262144 xq262144 merged commit f59b191 into develop Dec 21, 2018
@laodouya laodouya deleted the feature/Makefile branch December 21, 2018 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xq262144 xq262144 xq262144 approved these changes

@leventeliu leventeliu leventeliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laodouya @xq262144 @leventeliu